Fixes operator pod restart on changing addon params #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after successfull installation, changing addon params is breaking the code and pods keep restarting. this fixes it. Signed-off-by: Shivam Mukhade <[email protected]>
tekton-robot
added
the
release-note
sm43
requested review from
savitaashture,
piyush-garg,
nikhil-thomas and
pradeepitm12
and removed request for
nikhil-thomas,
piyush-garg and
pradeepitm12
tekton-robot
added
the
size/S
With this pr ko-build/ko#628 getting merged operator Make apply is gives below error ```cat building github.com/google/ko/cmd/ko… cannot find package "github.com/google/ko/cmd/ko" in any of: /usr/local/go/src/github.com/google/ko/cmd/ko (from $GOROOT) /tmp/tmp.rXMejzqfMj/src/github.com/google/ko/cmd/ko (from $GOPATH) make: *** [Makefile:26: /home/pradeepkumar/go/src/github.com/tektoncd/operator/.bin/ko] Error 1 ``` Signed-off-by: Pradeep Kumar <[email protected]>
|
/approve |
tekton-robot
added
the
approved
tekton-robot
added
size/M
Freeze ko version to v0.9.3 as latest version fails to build on go 1.16.13 Use `GO111MODULE=on` as `@version` syntax in go get will not work in non GO mod `go: can only use path@version syntax with 'go get' and 'go install' in module-aware mode` Signed-off-by: Nikhil Thomas <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after successfull installation, changing addon params is breaking
the code and pods keep restarting.
this fixes it.
#631 with some additional changes
Signed-off-by: Shivam Mukhade [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes